Nested with __pragma__(...)#692
Open
happy-monk wants to merge 2 commits intoTranscryptOrg:dev_fall_2019from
Open
Nested with __pragma__(...)#692happy-monk wants to merge 2 commits intoTranscryptOrg:dev_fall_2019from
with __pragma__(...)#692happy-monk wants to merge 2 commits intoTranscryptOrg:dev_fall_2019from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping on working for #552
In this changeset I've implemented stack for flags set and reset by pragmas. This allows us to solve
with __pragma__nesting problem.There is also
__pragma__('push')and__pragma__('pop')for saving and restoring flag state from stack. I plan to use those to fix the same nesting problem for single-line activated pragmas.Aliases cannot be nested yet.
The tests is a bit lacking. I think, snapshot testing could be better soultion for testing pragmas.